Why doesn't my script work. I try to create a vector in dependecy of variable without a loop. I'm not sure how i have to define the vector before the if cases

2 views (last 30 days)
if true
% code
z=0:1:4000;
g_1=0;
g_2=0;
v(z)=NaN(length(z));
for b=1:length(z)
if z<2000
v(z)=1500+z*g_1;
elseif z>=2000
v(z)=2000+z*g_2;
end
end
end

Accepted Answer

Birdman
Birdman on 16 Nov 2017
z=0:1:4000;
g_1=0;
g_2=0;
v=NaN(1,length(z));
for b=1:length(z)
if z(b)<2000
v(b)=1500+z(b)*g_1;
elseif z(b)>=2000
v(b)=2000+z(b)*g_2;
end
end
  3 Comments
Stephen23
Stephen23 on 16 Nov 2017
@Sebastian: you would be better off learning how to use MATLAB effectively. See KL's answer for a much neater solution.
Jan
Jan on 25 Nov 2017
I mention this, because it occurs in many code posted in the forum:
After
if z(b)<2000
it is useless to check for:
elseif z(b)>=2000
A simple else is sufficient already: It runs faster and the simpler code reduces the chance for typos.
This is not really important for Sebastian's question, but recommending to omit redundant code will make it easier to debug and maintain the code in general.

Sign in to comment.

More Answers (1)

KL
KL on 16 Nov 2017
No need for a loop, use logical indexing. Here's a better way to write that,
indx = z<2000;
v(indx) = 1500+z(indx)*g_1;
v(~indx)=2000+z(~indx)*g_2;
  4 Comments
Jan
Jan on 25 Nov 2017
+1. Or shorter:
idx = (z >= 2000);
v = 1500 + 500 * idx + z .* (g_1 .* (~idx) + g_2 .* idx);
With reordering the terms this is running 3 times faster:
v = (1500 + z .* g_1) .* ~idx + (2000 + z.* g_2) .* idx;

Sign in to comment.

Categories

Find more on Function Creation in Help Center and File Exchange

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!