Stuck on while loop, and cant get script to call out answer from function.
Show older comments
fprintf('This program will convert numbers between hexadecimal,\n');
fprintf('binary, and integers. Choose one of the below options:\n\n');
fprintf('1-Convert Binary to Integer\n');
fprintf('2-Convert Hexadecimal to Integer\n');
fprintf('X-Exit the program\n');
fprintf('\n');
%------------------------------------------------------------------------%
myoption = 0;
myInt = 0;
myHex = '00';
myBinary = '00000000';
%------------------------------------------------------------------------%
myoption = input('Enter an option: \n', 's');
while myoption ~= 'X'
if str2double(myoption) == 1
run myBinToInt;
else str2double(myoption) == 2
run myHexToInt
end
end
fprintf('The Binary number%s, converted to integer is: \n', myBinary);
fprintf('Integer = %d\n', myInt);
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
That is my script i want it to give me the binarynumber from the function and also to quit once it is done.
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
function myBinToInt(str) %Function to convert Binary number to Integer.
myBinary = input ('Enter a binary number: ', 's');
myInt = 0; %Initializes the int to zero.
i =1; %Initializes the i variable to 1.
while i < length(myBinary) + 1
myInt = myInt + str2double(myBinary(i)) * 2^(length(myBinary) - i);
i = i + 1;
end
end
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
This is the function.
I dont know what im doing wrong ive been trying for over 4 hours any help would be appreciated. Also, anyone know how i could get 'X' and 'x' to quit the program?
3 Comments
CokePQ
on 15 Feb 2015
Edited: Geoff Hayes
on 15 Feb 2015
CokePQ
on 15 Feb 2015
Your code is currently very difficult to read. Please learn to format your code correctly on this forum. You can use the {} Code button that you will find above the text box. Also very useful is the preview panel underneath the text box, which shows what you text will look like.
Please edit your question and comment and format the code correctly.
Accepted Answer
Geoff Hayes
on 15 Feb 2015
CokePQ - it seems that you are correctly able to call your myBinToInt function from your script (thought you don't need to invoke run before the function name) so could just have
myoption = input('Enter an option: \n', 's');
if str2double(myoption) == 1
myBinToInt;
elseif str2double(myoption) == 2
myHexToInt;
elseif myoption == 'X' | myoption == 'x'
disp('The program will now quit.')
else
% run Convert
end
If you want to have your myBinToInt function display the answer (of the binary to integer conversion), then just use fprintf to write the answer to the console. The following could be added after the code exits the while loop
fprintf('The conversion of the binary string %s to an integer is %d\n',myBinary,myInt);
Note that your function signature for myBinToInt includes a str input parameter which is unused (so this could be removed).
One of your other questions was how to exit the outer program if the user enters 'X' or 'x'. Just use strcmpi to check for this (the function is case insensitive)
elseif strcmpi(myoption'x') == 1
disp('The program will now quit.')
24 Comments
CokePQ
on 15 Feb 2015
Geoff Hayes
on 15 Feb 2015
You will need to modify your function signature so that it returns the binary number and the integer equivalent. Something like
function [myBinary, myInt] = myBinToInt
% etc.
Then, in your script, you would call this function as
if str2double(myoption) == 1
[myBinary, myInt] = myBinToInt;
fprintf('The Binary number %s, converted to integer is %d\n', myBinary, myInt);
elseif str2double(myoption) == 2
% etc.
Note that the fprintf is moved to the if body since for the other cases (conversion from hex to int) you will not want to print out the binary statement (as it makes no sense).
CokePQ
on 15 Feb 2015
CokePQ
on 15 Feb 2015
CokePQ
on 15 Feb 2015
CokePQ
on 15 Feb 2015
CokePQ
on 15 Feb 2015
Geoff Hayes
on 15 Feb 2015
Use regexp to check for existence of numbers that aren't 0 or 1. For example,
regexp('1111','[^01]')
returns an empty matrix, whereas
regexp('11112','[^01]')
returns 5.
CokePQ
on 15 Feb 2015
Image Analyst
on 15 Feb 2015
And we're supposed to know what functions you used in class? Please list them.
CokePQ
on 15 Feb 2015
Geoff Hayes
on 15 Feb 2015
CokePQ - since this is homework, then you must flag your question with the homework tag.
As for checking whether the input string has a character that is neither a '0' nor a '1', then use a for loop to iterate over each element of the string.
CokePQ
on 15 Feb 2015
CokePQ
on 16 Feb 2015
Geoff Hayes
on 16 Feb 2015
Your code iterates over c, from 1 to the length of myHex, but no where does it make use of c. I suspect that at each iteration of the loop you should access the cth element from myHex and use that in your if statement checks.
As I mentioned before, use strcmpi for when you want to compare the cth element of myHex with (for example) A or a (it is much simpler/cleaner).
Why not just use hex2num ? MATLAB already does this conversion quickly and neatly, and it makes your function much neater, faster and robust:
function [myHex, myInt] = myHexToInt
% Prompt User to input a Hexadecimal number, conver this to integer.
myHex = input('Enter a Hex number: \n', 's');
myInt = hex2dec(myHex);
end
And you can call it in the command window like this:
>> [A,B] = myHexToInt
Enter a Hex number:
2d
A = 2d
B = 45
CokePQ
on 17 Feb 2015
CokePQ
on 17 Feb 2015
CokePQ
on 17 Feb 2015
CokePQ
on 17 Feb 2015
CokePQ
on 17 Feb 2015
CokePQ
on 17 Feb 2015
CokePQ
on 17 Feb 2015
CokePQ
on 17 Feb 2015
More Answers (0)
Categories
Find more on Characters and Strings in Help Center and File Exchange
Community Treasure Hunt
Find the treasures in MATLAB Central and discover how the community can help you!
Start Hunting!
